Fix ClassMetadaInfo template inference#8708
Merged
greg0ire merged 1 commit intodoctrine:2.9.xfrom May 25, 2021
VincentLanglet:patch-2
Merged
Fix ClassMetadaInfo template inference#8708greg0ire merged 1 commit intodoctrine:2.9.xfrom VincentLanglet:patch-2
greg0ire merged 1 commit intodoctrine:2.9.xfrom
VincentLanglet:patch-2
Conversation
Member
|
I think 2.8.x is no longer maintained, or should not be, that's why I re-targeted this, let's see what happens to #8717 |
greg0ire
approved these changes
May 25, 2021
Member
|
Thanks @VincentLanglet ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @greg0ire, I saw you fixed some psalm issue recently
6de321c
Currently the following code
is not working, since
new ClassMetadata($class)is inferred asClassMetadata<object>.Which lead to weird static analysis issue in 2.8.5 release.
I fix this in this PR.