[GH-6578] Add validation that inherited entity class is mapped in discriminator.#8378
Merged
beberlei merged 2 commits intodoctrine:2.9.xfrom Apr 10, 2021
Conversation
65c82aa to
8d1a5ce
Compare
…d in discriminator.
8d1a5ce to
3c5c8a0
Compare
vovkin
reviewed
May 31, 2021
| } | ||
| } | ||
|
|
||
| if (! $class->isInheritanceTypeNone() && ! $class->isRootEntity() && array_search($class->name, $class->discriminatorMap) === false) { |
There was a problem hiding this comment.
Hello @beberlei,
shouldn't we skip this for abstract classes?
They were allowed to not be a part of mapping, but just be parent class for classes that are mapped in the root entity.
Now with update to Doctrine version 2.9.1 we are getting this error by schema validator
Entity class 'App\Entity\Order\CardSuborder' is part of inheritance hierarchy, but is not mapped in the root entity 'App\Entity\Suborder' discriminator map. All subclasses must be listed in the discriminator map.
where Suborder is a root entity, and CardSuborder is an abstract class extended from it, and then we have other not abstract classes extended from CardSuborder, and mapped in Suborder.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without tests as not failing all the schema validator tests with our existing models is proof enough, i flipped a condition to see it breaking hard.
Supersedes #6578
Fixes #6558