Set of tests for paginator with entities where id is custom object#7890
Set of tests for paginator with entities where id is custom object#7890akorz wants to merge 1 commit intodoctrine:2.6from akorz:2.6
Conversation
|
These diffs are still massive - we most certainly need to reduce them to just the minimum viable requirement to understand the failure :S |
|
@Ocramius Why? Do you have tests for paginator in your master branch for entities where id is custom object? No. I added them. Along that tests you can see 1 error. That's it. Let's imaging, I added just 1 test. But how can you be sure that all other things with paginator are still ok? |
|
I had added them to GH7820 if I remember correctly? The problem is that a lot of unrelated stuff got committed here, which makes it really hard to understand which detail to look for. |
|
Do you mean #7820 is a reason of error? Yes. You tried to create patch #7865 but with no success in my case. Please check Paginator tests in 2.6 branch. You can see a lot of entities are related with that tests. I created similar entities with custom id. Thats why diff is huge. But if it's necessary for getting things done what else should I do? :) |
|
@Ocramius Hello, did you have any chance to check it out? Thanks. |
|
Heya, as mentioned above, the diff is too big to evaluate properly. If you take #7821, for example, I tried isolating everything into GH7820Test |
|
continued in #7903 |
See more #7837