Skip to content

Update doctrine/coding-standard in 2.x branch#7350

Closed
ostrolucky wants to merge 1 commit intodoctrine:2.6from
ostrolucky:cs-2.6
Closed

Update doctrine/coding-standard in 2.x branch#7350
ostrolucky wants to merge 1 commit intodoctrine:2.6from
ostrolucky:cs-2.6

Conversation

@ostrolucky
Copy link
Copy Markdown
Member

@ostrolucky ostrolucky commented Aug 10, 2018 •
edited
Loading

@Majkl578
Copy link
Copy Markdown
Contributor

Majkl578 commented Aug 10, 2018

Any particular reason for this? We don't enforce CS in 2.x at all. For 2.7 we could at least consider the approach DBAL uses with CS checked on patch level.

@ostrolucky
Copy link
Copy Markdown
Member Author

ostrolucky commented Aug 10, 2018

See referenced comment. Reason is to allow contributors to check new code if they want, without team member having to point them out.

Having CI not enforcing this does not mean we don't waste time by back and forth talk about CS in PRs by humans.

@Majkl578
Copy link
Copy Markdown
Contributor

Majkl578 commented Aug 11, 2018

I don't see how this helps when you can't even run vendor/bin/phpcs.

@Majkl578 Majkl578 requested a review from Ocramius August 11, 2018 14:28
@ostrolucky
Copy link
Copy Markdown
Member Author

ostrolucky commented Aug 11, 2018

What do you mean I can't? I can and I did. I add NewFile.php, I run vendor/bin/phpcs NewFile.php and fix errors.

@Majkl578 Majkl578 mentioned this pull request Nov 14, 2018
Merged
@ostrolucky
Copy link
Copy Markdown
Member Author

ostrolucky commented Nov 14, 2018

Replaced with #7473

@ostrolucky ostrolucky closed this Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ocramius Ocramius Awaiting requested review from Ocramius

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ostrolucky @Majkl578