Fix preFlush event documentation stating incorrectly that flush can be called safely#6858
Closed
egonolieux wants to merge 1 commit intodoctrine:masterfrom
egonolieux:master
Closed
Fix preFlush event documentation stating incorrectly that flush can be called safely#6858egonolieux wants to merge 1 commit intodoctrine:masterfrom egonolieux:master
egonolieux wants to merge 1 commit intodoctrine:masterfrom
egonolieux:master
Conversation
Majkl578
reviewed
Dec 13, 2017
| anything else. ``EntityManager#flush()`` can be called safely | ||
| inside its listeners. | ||
| anything else. ``EntityManager#flush()`` should never be called inside its listeners, | ||
| because it will cause an infinite recursive call. |
Contributor
There was a problem hiding this comment.
Can we replace cause an infinite recursive call with result in an undefined behavior? That doesn't expose implementation and covers other potential issues as well.
Author
There was a problem hiding this comment.
Yes, a more general explanation might be better indeed.
Member
There was a problem hiding this comment.
Also "should never be called inside its listeners" is misleading because it really depends on the type of listener you're using and how flush() is being called.
Author
There was a problem hiding this comment.
What do you mean by "the type of the listener"? This is specifically about preFlush.
Member
There was a problem hiding this comment.
That comment was just wrong, sorry... too sleepy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.