Remove copy() method from EntityManager#6794
Remove copy() method from EntityManager#6794Majkl578 merged 1 commit intodoctrine:developfrom SenseException:remove-copy-method
Conversation
|
FYI, this PR should target develop as it's the development branch for 3.0.
IMO, no.
Yes. Deprecation needs to happen in master. |
|
@alcaeus Should I close this PR and recreate it with a branch from develop for the copy-removal? |
|
You can rebase this branch on top of develop and change the base of the pull request: |
|
@guilhermeblanco was rebasing develop to sync with the latest changes in master, so I'd recommend to ensure that he's done with it before of merging this PR |
|
The deprecation PR to master will follow. |
|
The deprecation PR is done in #6803. |
9f5fd37 to
e7d61c2
Compare
|
This will need a rebase now. |
Majkl578
left a comment
There was a problem hiding this comment.
LGTM.
Travis build is missing for unknown reason but it's tests are currently not working on develop branch anyway.
|
@SenseException Thanks. Let's handle deprecation for 2.x in #6803 now. |
The method
EntityManager::copy()is a pretty old addition to Doctrine and never got any functionality, which is why I created this PR to remove this method from theEntityManager.Because I had to remove this method from
EntityManagerInterfacetoo, I consider this a BC break. Even though the originalEntityManagernever got any functionality for copy, a user may have created a custom entity manager for a project, that uses a custom implementation of copy.Questions: