Revert "Fix fields of transient classes being considered duplicate with reportFieldsWhereDeclared (#11769)"#12212
Merged
greg0ire merged 1 commit intodoctrine:2.20.xfrom Oct 10, 2025
Merged
Conversation
…th `reportFieldsWhereDeclared` (doctrine#11769)" This reverts commit 4feaa47.
greg0ire
approved these changes
Oct 9, 2025
SenseException
approved these changes
Oct 9, 2025
Member
|
Thanks @mpdude ! |
|
|
||
| if ($this->isTransient($declaringClass)) { | ||
| return isset($metadata->fieldMappings[$property->name]); | ||
| } |
There was a problem hiding this comment.
removing this condition is breaking my project, check this issue #12246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #11769 (comment), I would like to revert the changes made in 4feaa47 (#11769).
Basically, it is wrong to allow fields from transient classes to be parsed and used for mapping configuration. This has happened and worked in the past, although it was never really endorsed or officially allowed by the documentation.
By adding the
reportFieldsWhereDeclaredopt-in switch (#10455), we were starting to enforce stricter configuration checks that help us to prevent other, strange errors further down the road. So, 4feaa47 was a step in the wrong direction.