Fix php doc for getPropertyAccessors method#12158
Closed
dmitryuk wants to merge 17 commits intodoctrine:3.6.xfrom
Closed
Fix php doc for getPropertyAccessors method#12158dmitryuk wants to merge 17 commits intodoctrine:3.6.xfrom
dmitryuk wants to merge 17 commits intodoctrine:3.6.xfrom
Conversation
… on to-many-collections This fixes that using a `Criteria` with an `IN` or `NIN` expression on a to-many collection currently leads to an SQL error (doctrine#6173). The `ManyToMany` persister needs to know about the slightly different SQL syntax for `[NOT] IN ()`. In the case of `[NOT] IN` expressions, the value will be an array, which also required me to change (I guess "fix") the parameter type handling. I have pulled the necessary code from the `BasicEntityPersister` and placed it as static helper methods in `PersisterHelper`. This is somewhat inspired by doctrine#11516, which aims at fixing doctrine#11481: By re-using the parameter type handling code, it also fixes using backed enums in `EQ`, `IN` and `NIN` expressions within `Criteria` when `matching()` on one-to-many and many-to-many collections.
It has been deprecated.
self::returnValue() and self::onConsecutiveCalls() has been deprecated.
It has been deprecated.
It seems that this could happen with PHPUnit 10, then tearDown() would crash when calling `clear()` on null, but then PHPUnit 10 did not show that exception.
…ression Fix `IN`/`NOT IN` expression handling and support enums when matching on to-many-collections
…trategies-dbal-4 docs: generation strategies: differences between DBAL 3 and 4
Merge 2.20.x up into 3.5.x
greg0ire
reviewed
Sep 9, 2025
greg0ire
reviewed
Sep 9, 2025
| * Gets the ReflectionProperties of the mapped class. | ||
| * Gets the PropertyAccessors of the mapped class. | ||
| * | ||
| * @return PropertyAccessor[] An array of PropertyAccessor instances. |
Member
There was a problem hiding this comment.
This does not mean list, this means array. So this was correct. Therefore, this change should target 3.6.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: