Merged
Conversation
In aa141bf, I wrongly assumed that $tableName would never contain a dot as I was not able to write a test that caused that to happen. The secret recipe appears to be to define a schema and to quote the table name. To fix it for the table name, I am calling quoteSingleIdentifier() before doing the concatenation between schema name and table name. To fix it for the sequence name, which seems only useful when using DBAL 3 for some reason, I reuse some of the logic of the deprecated method. Fixes doctrine#12041
That test was testing too many thing and not really making it clear what the expected output was, given some output. Instead, let us create 2 tests, each pertaining to the class under test.
This comment is rendered useless by the phpdoc comment below it. Instead, we can comment on what exactly "quoted" means.
Quote parts of the table name
….6.x_OhbrLWrh Merge release 3.5.1 into 3.6.x
* 3.6.x: Include stability in coverage file key (doctrine#12112) Allow Symfony 8 (doctrine#12110) Run tests with Symfony 8 (doctrine#12102) Improve comment Convert test into 2 unit tests Quote parts of the table name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.