Update baseline because of doctrine/dbal 4.3.0#12072
Merged
greg0ire merged 1 commit intodoctrine:3.5.xfrom Jul 12, 2025
Merged
Conversation
Member
Author
|
I need to adjust the DBAL3 baseline as well. |
This should fix the build. Maybe some of the reported issues can be addressed, but if that is the case, it should probably be done on the next minor branch.
48e762b to
137ecb4
Compare
| message: '#^Parameter \#1 \$columns of method Doctrine\\DBAL\\Platforms\\AbstractPlatform\:\:getColumnDeclarationListSQL\(\) expects list\<array\{name\: string, type\: Doctrine\\DBAL\\Types\\Type, default\: mixed, notnull\?\: bool, autoincrement\: bool, columnDefinition\: non\-empty\-string\|null, comment\: string, charset\?\: non\-empty\-string\|null, \.\.\.\}\>, array\<string, array\{name\: string, notnull\: true, type\: Doctrine\\DBAL\\Types\\Type\}\> given\.$#' | ||
| identifier: argument.type | ||
| count: 1 | ||
| path: src/Query/Exec/MultiTableUpdateExecutor.php |
Member
There was a problem hiding this comment.
There's also a way to define multiple paths if you want to group the same errors in this baseline file. It would reduce the file size and give a better view on where the same error happens in the project..
https://phpstan.org/user-guide/ignoring-errors#ignoring-in-configuration-file
Member
Author
There was a problem hiding this comment.
I generated this one file , and I think everyone does the same
Member
There was a problem hiding this comment.
I was referring to
paths:
- some/path
- other/pathin the docs for the errors with the same or similar message, but I didn't make this to a change request, because it would only be a simple improvement and no blocker. 🙂
derrabus
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the build. Maybe some of the reported issues can be addressed, but if that is the case, it should probably be done on the next minor branch.