Bugfix: Missed a spot using getUnderlyingReflector#11873
Merged
greg0ire merged 1 commit intodoctrine:3.4.xfrom Mar 16, 2025
Merged
Bugfix: Missed a spot using getUnderlyingReflector#11873greg0ire merged 1 commit intodoctrine:3.4.xfrom
greg0ire merged 1 commit intodoctrine:3.4.xfrom
Conversation
3 tasks
a6ec45e to
e29d0e9
Compare
|
Test suite is green with this patch indeed. Thanks @beberlei ! |
greg0ire
approved these changes
Mar 16, 2025
Member
greg0ire
left a comment
There was a problem hiding this comment.
Would be nice to have a failing test for this
Member
Member
Author
|
I think, a test is overrated here, if this was changed within the original PR alraedy you wouldn't have spotted this is untested. Considering as the failing line was added in the previous PR in one commit and not adjusted to the API used here when it was introduced to fix these problems in a later commit. The new API is required to be used for accessing property accessors, not using it can be statically assed to be wrong and that this is the fix. |
Member
|
Fair enough, let's merge this then |
|
Thanks! |
Member
|
The reason that it wasn't spotted in the first PR means it is more likely that we might break it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably fixes problems described with patch #11659
This is a spot missed using the
PropertyAccessor::getUnderlyingReflectorAPI that was introduced for these kinds of problems. Weirdly the tests pass, even though the errors described in PR should occur with any embeddable, which there are many off.