Update message of ORMInvalidArgumentException#11845
Merged
greg0ire merged 2 commits intodoctrine:2.20.xfrom Mar 24, 2025
Merged
Update message of ORMInvalidArgumentException#11845greg0ire merged 2 commits intodoctrine:2.20.xfrom
ORMInvalidArgumentException#11845greg0ire merged 2 commits intodoctrine:2.20.xfrom
Conversation
update message to use attribute instead of annotation
derrabus
approved these changes
Feb 21, 2025
ORMInvalidArgumentException
derrabus
previously requested changes
Feb 21, 2025
Member
derrabus
left a comment
There was a problem hiding this comment.
I think you need to escape the quotes in the exception message.
Contributor
Author
|
Escaped |
Member
|
You will need to update the tests as well. |
121c3d6 to
2d2a344
Compare
SenseException
approved these changes
Mar 23, 2025
The requested changes have been applied
Member
|
Thanks @lacatoire ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update message to use attribute instead of annotation