Skip to content

Fix Events::onFlush and PostFlush() documentation: events are always raised#11709

Merged
greg0ire merged 1 commit intodoctrine:2.20.xfrom
lyrixx:fix-event-doc
Nov 18, 2024
Merged

Fix Events::onFlush and PostFlush() documentation: events are always raised#11709
greg0ire merged 1 commit intodoctrine:2.20.xfrom
lyrixx:fix-event-doc

Conversation

@lyrixx
Copy link
Copy Markdown
Contributor

@lyrixx lyrixx commented Nov 7, 2024 •
edited
Loading

Improvement

Q A
New Feature no
RFC no
BC Break no

Summary

see

orm/src/UnitOfWork.php

Lines 399 to 413 in 9e2bfa8

if (
! ($this->entityInsertions ||
$this->entityDeletions ||
$this->entityUpdates ||
$this->collectionUpdates ||
$this->collectionDeletions ||
$this->orphanRemovals)
) {
$this->dispatchOnFlushEvent();
$this->dispatchPostFlushEvent();
$this->postCommitCleanup($entity);
return; // Nothing to do.
}

@greg0ire greg0ire added this to the 2.20.1 milestone Nov 18, 2024
@greg0ire greg0ire merged commit 58ad1d9 into doctrine:2.20.x Nov 18, 2024
@greg0ire
Copy link
Copy Markdown
Member

greg0ire commented Nov 18, 2024

Thanks @lyrixx !

@lyrixx lyrixx deleted the fix-event-doc branch November 18, 2024 22:39
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@beberlei beberlei Awaiting requested review from beberlei

@derrabus derrabus Awaiting requested review from derrabus

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

2.20.1

Development

Successfully merging this pull request may close these issues.

3 participants

@lyrixx @greg0ire @SenseException