Experiment with literalinclude#11667
Merged
greg0ire merged 1 commit intodoctrine:2.20.xfrom Oct 14, 2024
Merged
Conversation
I think it would be great to use literalinclude for big code snippets, because our IDEs could warn us about issues, and it would be easily to showcase our coding standard. Before we do that though, let us validate that it renders as expected. I have picked a complex example where we have a configuration block.
Member
As in "It doesn't throw errors in the workflow" or if it looks the same? |
Member
Author
|
As in "it looks the same" (but the fact that it doesn't throw errors in the workflow is nice already). I'd like to merge and deploy the website, then check https://www.doctrine-project.org/projects/doctrine-orm/en/2.20/tutorials/working-with-indexed-associations.html#working-with-indexed-associations |
SenseException
approved these changes
Oct 13, 2024
derrabus
approved these changes
Oct 13, 2024
Member
Author
|
Argh! The block disappeared 😧 Trying to understand it at https://doctrine.slack.com/archives/CERGRHPGD/p1729058112014159 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be great to use
literalincludefor big code snippets, because our IDEs could warn us about issues, and it would be easily to showcase our coding standard. Before we do that though, let us validate that it renders as expected. I have picked a complex example where we have a configuration block.