Do not defer eager collection loading when in iteration context#11082
Merged
greg0ire merged 2 commits intodoctrine:2.17.xfrom Jan 10, 2024
Merged
Do not defer eager collection loading when in iteration context#11082greg0ire merged 2 commits intodoctrine:2.17.xfrom
greg0ire merged 2 commits intodoctrine:2.17.xfrom
Conversation
This test show that eager collections are broken when used in conjuction with iterating over a result.
Contributor
Author
|
@beberlei Any chance you can take a look at this? This is blocking our upgrade to 2.17 |
Contributor
Author
greg0ire
approved these changes
Jan 9, 2024
SenseException
approved these changes
Jan 9, 2024
Member
|
Thanks @bobvandevijver ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test shows that eager collection loading is broken when used in conjunction with iterating over a query result. I also added a proposed fix to not defer eager collection loading when the iteration hint has been set.
Fixes #11081