Fixes #10715 - Incorrect subclasses dependencies weight while calculating commit orders#10716
Closed
sylfabre wants to merge 1 commit intodoctrine:2.15.xfrom
Closed
Fixes #10715 - Incorrect subclasses dependencies weight while calculating commit orders#10716sylfabre wants to merge 1 commit intodoctrine:2.15.xfrom
sylfabre wants to merge 1 commit intodoctrine:2.15.xfrom
Conversation
Contributor
Author
|
I would like to add a functional test to prove the bug and that my fix is working but I don't know how to do it:
Thanks 🙏 |
Contributor
|
Hey there 👋🏼, I am actively working on major changes to the commit order computation. Could you please have a look at #10547 and/or try if the branch |
21 tasks
Contributor
Author
|
This PR is replaced by https://github.com/doctrine/orm/pull/10547/files Thanks @mpdude |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #10715
It makes
UnitOfWork::getCommitOrder()use consistent weight for both the parent class and subclasses' dependencies