Merged
Conversation
derrabus
commented
Feb 3, 2023
d78f71c to
85531c0
Compare
85531c0 to
96caa99
Compare
derrabus
commented
Feb 3, 2023
derrabus
commented
Feb 3, 2023
tests/Doctrine/Tests/PHPUnitCompatibility/OnNotSuccessfulTestCompat.php
Outdated
Show resolved
Hide resolved
9f8e04e to
36489c0
Compare
36489c0 to
15c6a08
Compare
This was referenced Feb 6, 2023
6c608dd to
900a288
Compare
900a288 to
0a477cf
Compare
0a477cf to
6f0294d
Compare
Member
Author
|
Targeting 3.0.x now because it does not really make sense to run the 2.x test suite with PHPUnit 10 as long as we need to support PHP 7.x there. |
667afec to
7a6899c
Compare
75a3f94 to
9bd394a
Compare
SenseException
requested changes
Mar 1, 2023
SenseException
approved these changes
Mar 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the test suite to PHPUnit 10.
I'm cherry-picking all changes to the lowest branch possible before marking this PR as ready.✅