Move runtime check for to-many associations in mapped superclasses to a more suitable place#10398
Closed
mpdude wants to merge 1 commit intodoctrine:2.15.xfrom
Closed
Move runtime check for to-many associations in mapped superclasses to a more suitable place#10398mpdude wants to merge 1 commit intodoctrine:2.15.xfrom
mpdude wants to merge 1 commit intodoctrine:2.15.xfrom
Conversation
… a more suitable place
0a790fa to
e34a185
Compare
Contributor
Author
Contributor
Author
|
X-Ref #9702 |
This was referenced Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing this since #10473 was merged; it removed the check altogether.
This PR moves the check that a mapped superclass does not declare to-many associations to a more suitable (IMHO) place.
It is no longer checked when another class inherits the association from the mapped superclass, but at the final runtime validation stage when loading the metadata for the mapped superclass itself.
In addition to that, can we review whether the check is correct for the case where we have
In other words, only the mapped superclass may not define to-many associations, but it is fine if an entity class above it does and when an entity class below inherits all that? My feeling is that should be fine.