Skip to content

Enhancement: Improve wording#9

Merged
Ocramius merged 1 commit intodoctrine:masterfrom
localheinz:patch-1
Jun 9, 2018
Merged

Enhancement: Improve wording#9
Ocramius merged 1 commit intodoctrine:masterfrom
localheinz:patch-1

Conversation

@localheinz
Copy link
Copy Markdown
Contributor

@localheinz localheinz commented Jun 9, 2018

This PR

  • attempts to improve the wording of a sentence that sounds a bit odd

Ocramius
Ocramius approved these changes Jun 9, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius self-assigned this Jun 9, 2018
@Ocramius Ocramius added the Documentation A change to the documentation. label Jun 9, 2018
@Ocramius Ocramius added this to the 1.0.0 milestone Jun 9, 2018
@Ocramius Ocramius merged commit 05a6f48 into doctrine:master Jun 9, 2018
@localheinz localheinz deleted the patch-1 branch June 10, 2018 07:26
@localheinz
Copy link
Copy Markdown
Contributor Author

localheinz commented Jun 10, 2018

Thank you, @jwage and @Ocramius!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwage jwage jwage approved these changes

+1 more reviewer

@Ocramius Ocramius Ocramius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ocramius Ocramius

Labels

Documentation A change to the documentation.

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@localheinz @jwage @Ocramius