Skip to content

Setup composer lint#55

Merged
greg0ire merged 1 commit intodoctrine:1.1.xfrom
greg0ire:composer-lint
Oct 10, 2022
Merged

Setup composer lint#55
greg0ire merged 1 commit intodoctrine:1.1.xfrom
greg0ire:composer-lint

Conversation

@greg0ire
Copy link
Copy Markdown
Member

No description provided.

@derrabus derrabus added the CI label Oct 10, 2022
@greg0ire greg0ire force-pushed the composer-lint branch 2 times, most recently from 9e9e45c to 168273a Compare October 10, 2022 19:41
@greg0ire greg0ire marked this pull request as ready for review October 10, 2022 19:42
@greg0ire greg0ire requested a review from derrabus October 10, 2022 19:42
@SenseException
Copy link
Copy Markdown
Member

Does it make sense to add a new workflow to doctrine/.github?

Comment on lines +19 to +20
with:
php-version: "8.1"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with:
php-version: "8.1"

Isn't that the default?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I copy/pasted from another repo.

@greg0ire greg0ire merged commit db0e2e7 into doctrine:1.1.x Oct 10, 2022
@greg0ire greg0ire added this to the 1.1.3 milestone Oct 10, 2022
@greg0ire greg0ire deleted the composer-lint branch October 10, 2022 21:11
@derrabus derrabus modified the milestones: 1.1.3, 1.2.0 Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants