Split getAllListeners() out of getListeners()#50
Merged
greg0ire merged 1 commit intodoctrine:1.2.xfrom Oct 10, 2022
Merged
Conversation
Member
|
Needs a rebase |
c6ab4e5 to
264302f
Compare
greg0ire
reviewed
Oct 10, 2022
greg0ire
reviewed
Oct 10, 2022
264302f to
13770c1
Compare
malarzm
approved these changes
Oct 10, 2022
greg0ire
approved these changes
Oct 10, 2022
Member
|
Thanks @derrabus ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While #46 kind of explained the current API to static analysers, I think we should split the two ways of calling
getListeners()into two separate methods. With this PR, I'd like to add a methodgetAllListeners()and deprecate callinggetListeners()without an event name. This should make the API a lot cleaner in a future 2.0 release.