Introduce EventManagerInterface#106
Merged
greg0ire merged 1 commit intodoctrine:2.1.xfrom Jan 29, 2026
Merged
Conversation
In theory, having small interfaces is great, but in practice, migrating
the ORM to them would involve DNF types, which are not available with
PHP 8.1, for use in e.g. the constructor of EntityManager.
public function __construct(
private Connection $conn,
private Configuration $config,
- EventManager|null $eventManager = null,
+ (EventListenerIntrospector&EventListenerRegistry&EventSubscriberRegistry)|null $eventManager = null,
) {
Member
Author
|
Converting to draft as I want to use this in Proof of concept ORM PRs |
Member
Author
|
Here is the PoC: doctrine/orm#12361 |
GromNaN
approved these changes
Jan 28, 2026
SenseException
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In theory, having small interfaces is great, but in practice, migrating the ORM to them would involve DNF types, which are not available with PHP 8.1, for use in e.g. the constructor of EntityManager.
public function __construct( private Connection $conn, private Configuration $config, - EventManager|null $eventManager = null, + (EventListenerIntrospector&EventListenerRegistry&EventSubscriberRegistry)|null $eventManager = null, ) {Targeting 2.1.x since this is more fixing a design blunder than an improvement.