Merged
Conversation
Contributor
Author
|
@greg0ire can you approve this? I run the tests locally and it seems to work flawlessly, without any further modifications. |
Closed
HypeMC
reviewed
Feb 6, 2026
Member
|
It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those. |
Contributor
Author
|
The PHPStan failure highlighted an issue in a test, where a stub was used instead of a mock. PHPUnit 13 uses stricter types to report this kind of failure, as explained by Sebastian himself in https://phpunit.expert/articles/the-stub-mock-intervention.html Fixed in 668536e, please approve the CI run |
greg0ire
approved these changes
Feb 7, 2026
Member
|
Thanks @Jean85 , released as https://github.com/doctrine/deprecations/releases/tag/1.1.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113