Deprecate AbstractAsset::_setName()#6610
Merged
morozov merged 1 commit intodoctrine:4.3.xfrom Nov 17, 2024
Merged
Conversation
571536c to
b2695ae
Compare
greg0ire
approved these changes
Nov 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oftentimes, objects are indexed by name (e.g. table columns or schema tables). There shouldn't be an API to modify the name of the object once it has been constructed. The existing cases where the object name is still modified will be addressed separately by introducing builders and creating a new object with the same properties but a new name.