Add the getColumnName() method to the Result interface#6452
Merged
derrabus merged 1 commit intodoctrine:5.0.xfrom Jun 19, 2024
Merged
Add the getColumnName() method to the Result interface#6452derrabus merged 1 commit intodoctrine:5.0.xfrom
getColumnName() method to the Result interface#6452derrabus merged 1 commit intodoctrine:5.0.xfrom
Conversation
… to the Result interface
greg0ire
approved these changes
Jun 19, 2024
stof
reviewed
Jun 19, 2024
| public function columnCount(): int; | ||
|
|
||
| /** | ||
| * Returns the name of the column in the result set for the given 0-based index. |
Member
There was a problem hiding this comment.
you should probably add the @throws Exception for consistency with other methods
Member
Author
There was a problem hiding this comment.
Good idea. If you don't send a PR, I'll do that tomorrow. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following #6428, the new
getColumnName()method becomes mandatory with this PR for allResultimplementations.