Stop considering generated column definition as being its default value#6199
Merged
derrabus merged 1 commit intodoctrine:3.9.xfrom Aug 14, 2024
Merged
Stop considering generated column definition as being its default value#6199derrabus merged 1 commit intodoctrine:3.9.xfrom
derrabus merged 1 commit intodoctrine:3.9.xfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pg_get_expr(adbin, adrelid)expression in Postgresql's internal tablepg_attrdefis used to know a column definitionfor most column, if this returns something, it means this column's default value. So DBAL has been considering has ALWAYS meaning it contains its default.
However for generated columns, it contains the value definition and not its default value, so we change the selectTableColumns' query to correctly set the 'default' column to
nullfor generated columnsIt will help setting correctly the column's attributes which in turn will help generate correct schema diff.