QueryBuilder must use 0-based positional parameter keys#4422
Merged
morozov merged 1 commit intodoctrine:3.0.xfrom Nov 11, 2020
Merged
QueryBuilder must use 0-based positional parameter keys#4422morozov merged 1 commit intodoctrine:3.0.xfrom
morozov merged 1 commit intodoctrine:3.0.xfrom
Conversation
greg0ire
reviewed
Nov 11, 2020
Member
greg0ire
left a comment
There was a problem hiding this comment.
Should the phpdoc of getParameters be changed to use list then?
Member
Author
|
No, because those can be named parameters as well or even a mix which is not allowed by the documentation but not enforced programmatically. |
SenseException
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4421.
Although this bug exists in
2.x, I don't think we have to fix it in a patch release. It's sufficient to fix it in3.0.x.