Rename Comparator::diffTable() params - from/to instead of 1/2#4337
Rename Comparator::diffTable() params - from/to instead of 1/2#4337greg0ire merged 1 commit intodoctrine:2.11.xfrom
Conversation
|
Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble. |
cdfa6f3 to
92337f0
Compare
|
@greg0ire squashed |
greg0ire
left a comment
There was a problem hiding this comment.
Let's do this before it becomes a BC-break 👍
92337f0 to
032b602
Compare
|
Rebasing because of new pipeline |
|
Thanks @mvorisek ! @morozov Codecov is behaving a bit weird, it seems to need time to process the ~50 reports we send, then it show the right percentage diff in Github's UI, but in its own UI, it's correct in some places, outdated and alarming in some others, for example the Coverage change tab is wrong and so is the Overview graph cc @thomasrockhu |
|
@greg0ire, this is indeed strange. Would you be able to open a ticket in our community boards? I'll take a look. |
|
Looks like it's fixed now, it just seems to take a lot of time. Should I still open the ticket? It will be hard for you to investigate anything I'm afraid. |
|
@greg0ire, ah got it. I'll keep an eye out, but if you see it happening, please feel free to open. |
Summary
swapping input of
Comparator::diffTablewill produce completely different result - the first gven table is expected to be the "from" table and the 2nd table is expected to be the "to" tablethe names are also consistent with
Comparator::compare(which uses$fromSchema,$toSchemanames)no more changes in
Comparatorclass needed -Comparator::diffSequenceuses$sequence1and$sequence2names, but the inputs can be swapped, so these names should stay