Update architecture documentation#4164
Merged
morozov merged 1 commit intodoctrine:3.0.xfrom Jul 11, 2020
Merged
Conversation
Member
morozov
commented
Jul 11, 2020
| Q | A |
|---|---|
| Type | improvement |
| BC Break | no |
1 task
greg0ire
reviewed
Jul 11, 2020
docs/en/reference/architecture.rst
Outdated
| ``Doctrine\DBAL\Statement`` add to the underlying driver | ||
| The DBAL consists of two layers: drivers and a wrapper. Each layer | ||
| is mainly defined in terms of 3 components: ``Connection``, | ||
| ```Statement`` and ``Result``. |
Member
There was a problem hiding this comment.
On my phone, but too many backticks here
docs/en/reference/architecture.rst
Outdated
| Apart from the three main components, a DBAL driver should also provide | ||
| an implementation of the ``Doctrine\DBAL\Driver`` interface that | ||
| implements the logic of translation of the DBAL connection parameters | ||
| to the ones specific to the given driver and provides factory methods |
Member
There was a problem hiding this comment.
Does the interface provide the factory methods? If not no s after provide
Member
Author
There was a problem hiding this comment.
Yeah, it was about "interface … provides" but it's clumsy and the sentence is too complex. Let me try to rephrase.
greg0ire
approved these changes
Jul 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.