Add some missing @throws annotations and fix thrown exceptions#4160
Merged
morozov merged 10 commits intodoctrine:3.0.xfrom Jul 10, 2020
Merged
Add some missing @throws annotations and fix thrown exceptions#4160morozov merged 10 commits intodoctrine:3.0.xfrom
morozov merged 10 commits intodoctrine:3.0.xfrom
Conversation
…ansactions Not only a connection exception is possible (e.g. it may be a connection failure or a failure to detect the platform).
ff16ff9 to
06a8fac
Compare
greg0ire
approved these changes
Jul 10, 2020
SenseException
approved these changes
Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roughly half of the error handling issues reported by PhpStorm have been fixed. The following categories of issues still need fixing:
Connection::getDatabasePlatform()can fail at literally any point in time.AbstractPlatform::get*DeclarationSQL()and similar methods should have a special type that could be declared as unchecked (e.g.LogicalException). Those are not meant to be handled at runtime (see the details).Type::getType()that technically may thrown an exception but practically doesn't and those cases are reported as not handling the exception (need a specialized exception-less API).Schemanamespace depends on theTypeone internally but doesn't handle its exceptions and therefore may throw a genericDBALException.DriverExceptioninstead of the genericDBALException.