@morozov Do you know what's wrong with phpcs? How can I early exit here?

Do you know what's wrong with phpcs? How can I early exit here?

Please try phpcbf:

--- a/lib/Doctrine/DBAL/Query/QueryParts.php
+++ b/lib/Doctrine/DBAL/Query/QueryParts.php
@@ -67,8 +67,10 @@ class QueryParts
             $this->where = clone $this->where;
         }
 
-        if ($this->having !== null) {
-            $this->having = clone $this->having;
+        if ($this->having === null) {
+            return;
         }
+
+        $this->having = clone $this->having;
     }
 }

See slevomat/coding-standard#371 for the reference.

Please try phpcbf: (...)

Kills readability in this specific case, if you ask me. Should I proceed anyway?

Kills readability in this specific case, if you ask me. Should I proceed anyway?

I agree (hence the issue). However, I'd prefer to format the code according to the standard instead of having to maintain an exception in phpcs.xml.

I agree (hence the issue). However, I'd prefer to format the code according to the standard instead of having to maintain an exception in phpcs.xml.

Fixed in 00b4f89.

I agree (hence the issue). However, I'd prefer to format the code according to the standard instead of having to maintain an exception in phpcs.xml.

Fixed in 00b4f89.

And obsoleted by 42c6062. Problem solved.

@morozov All good for me. Let me know if you see anything else!

@morozov All done! Ready for your review.

@morozov Ready for review, once again.

Squashed!

@BenMorel after getting this done, if you’re still in the mood for static analysis puzzles like this, you may want to look at #3799. There was some progress done in the past but it seems stuck.

Please use $this->expectException() instead.

Ugh. All assertions are static, and this method isn't. How can this even work??

Anyway, all fixed, and squashed again.

Thanks, @BenMorel! All good this time.