Made the OCI8Statement class final#3820
Merged
Ocramius merged 2 commits intodoctrine:masterfrom Jan 13, 2020
Merged
Conversation
Ocramius
approved these changes
Jan 13, 2020
|
|
||
| ## BC BREAK: Dropped handling of one-based numeric arrays of parameters in `Statement::execute()` | ||
|
|
||
| The statement implementations no longer detect whether `$params` is a zero- or one-based array. A zero-based numeric array is expected. |
Member
There was a problem hiding this comment.
We should probably start adding @psalm-param list<T> for these
Member
Author
There was a problem hiding this comment.
Should we add Psalm to the build pipeline first? Consumers using Psalm will benefit from those annotations regardless but we want to make sure those annotations are valid and kept up to date.
Member
There was a problem hiding this comment.
Sure thing - it's a big amount of work to get it to "like" our codebase though 😅
6 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OCI8Statement::convertPositionalToNamedPlaceholders()method is extracted to an internal utility class in order to enable making the class final. The corresponding test methods are extracted fromUtilTestandOCI8StatementTestto the dedicated test class.OCI8StatementTesthas been removed since it doesn't contain any more tests which is a good sign: we're not testing any driver-specific implementation details on the driver class itself.