Skip to content

Dropped SQL Server 2008 support#3756

Merged
morozov merged 2 commits intodoctrine:masterfrom
morozov:issues/3755
Dec 5, 2019
Merged

Dropped SQL Server 2008 support#3756
morozov merged 2 commits intodoctrine:masterfrom
morozov:issues/3755

Conversation

@morozov
Copy link
Copy Markdown
Member

@morozov morozov commented Nov 28, 2019 •
edited
Loading

Q A
Type improvement
BC Break yes

Fixes #3755.

Additionally, some changes in .appveyor.yml were needed in order to work around the build failure. The reason is:

  1. Due to Not all package versions are returned when running running choco list --all-versions --exact chocolatey/choco#1843, choco search only returns PHP 7.4.0 as of today: 
    PS C:\Users\Sergei Morozov> choco search php --exact --all-versions
Chocolatey v0.10.15
php 7.4.0 [Approved]
1 packages found.
  2. Combined with | select-string -pattern 7.3, it yields an empty list and fails the build.
  3. Prior to this change, the builds would pass because all runtime dependencies are cached based on the content of .appveyor.yml.
  4. We cannot switch to PHP 7.4 on AppVeyor because the corresponding sqlsrv and pdo_sqlsrv binaries are not yet available.

@morozov morozov added this to the 3.0.0 milestone Nov 28, 2019
@morozov morozov requested review from Ocramius and lcobucci November 28, 2019 05:15
@morozov
Dropped SQL Server 2008 support
5847a60
@morozov
Temporarily switching to a hard-coded PHP vesion
eb3b1b3 
Chocolatey returns only 7.4.0 in the search results but there's no SQL Server extensions released for it yet.
@SenseException
Copy link
Copy Markdown
Member

SenseException commented Dec 5, 2019

Are we going to create a new PR for having sqlsrv and pdo_sqlsrv with PHP 7.4 when it is available? Or do you want to try to find another solution?

@morozov
Copy link
Copy Markdown
Member Author

morozov commented Dec 5, 2019

Are we going to create a new PR for having sqlsrv and pdo_sqlsrv with PHP 7.4 when it is available? Or do you want to try to find another solution?

Apparently, the 5.7.1preview builds are compiled for PHP 7.4 but I'd rather solve one problem at a time.

@morozov morozov merged commit a901523 into doctrine:master Dec 5, 2019
@morozov morozov deleted the issues/3755 branch December 5, 2019 23:39
@beberlei
Copy link
Copy Markdown
Member

beberlei commented Dec 7, 2019

@morozov this needs to get into 2.10 as well as appveyor is mass failing there as well

@morozov morozov mentioned this pull request Dec 19, 2019
Merged
@morozov morozov self-assigned this Jan 22, 2020
This was referenced Mar 18, 2020
Closed
Merged
@morozov morozov modified the milestones: 4.0.0, 3.0.0 Mar 19, 2020
@morozov morozov mentioned this pull request Jan 20, 2021
Merged
@morozov morozov mentioned this pull request Aug 24, 2021
Merged
This was referenced Oct 30, 2021
Closed
Closed
@morozov morozov mentioned this pull request Dec 8, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SenseException SenseException SenseException approved these changes

@Ocramius Ocramius Awaiting requested review from Ocramius

@lcobucci lcobucci Awaiting requested review from lcobucci

Assignees

@morozov morozov

Labels

BC Break Improvement SQL Server

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Drop support for SQL Server 2008

3 participants

@morozov @SenseException @beberlei