Implement {Configuration#getSchemaAssetsFilter}#3308
Merged
morozov merged 1 commit intodoctrine:masterfrom Oct 6, 2018
Merged
Conversation
morozov
reviewed
Oct 5, 2018
Member
morozov
left a comment
There was a problem hiding this comment.
@bezhermoso, the patch looks good overall. Please see a few comments.
Contributor
Author
|
@morozov, I think I addressed your comments. Let me know if I miss anything. |
morozov
reviewed
Oct 5, 2018
ae88543 to
348e600
Compare
348e600 to
5110a19
Compare
Member
|
Thank you, @bezhermoso. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gives ability to specify a callable to use for filtering schemas by potentially something other than regular expressions. Implements what's laid out by @morozov in his comment: #3196 (comment)