Skip to content

CI: Test against MySQL 8.0 on Travis#3183

Closed
Majkl578 wants to merge 3 commits intodoctrine:masterfrom
Majkl578:ci-mysql8
Closed

CI: Test against MySQL 8.0 on Travis#3183
Majkl578 wants to merge 3 commits intodoctrine:masterfrom
Majkl578:ci-mysql8

Conversation

@Majkl578
Copy link
Copy Markdown
Contributor

Q A
Type improvement
BC Break no

Summary

Testing MySQL 8.0 on Travis.

@morozov
Copy link
Copy Markdown
Member

morozov commented Jun 15, 2018

There's one more failure I inconsistently see on MySQL 8:

1) Doctrine\Tests\DBAL\Functional\Schema\MySqlSchemaManagerTest::testAlterTableScenario
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'foo'
-    1 => 'foreign_key_test'
+    0 => 'foreign_key_test'
+    1 => 'foo'
 )

There must be the same reason as for the previously fixed failure.


echo "Starting MySQL 8.0..."

echo -e "[mysqld]\ndefault_authentication_plugin=mysql_native_password" > /tmp/mysql-auth.cnf
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, this file cannot be directly created in the container because by the moment the container has started, the configuration will have been read, and the newly created file will be ignored. Right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is done according to documentation and is a standard way to provide custom configs to dockerized services:

Using a custom MySQL configuration file
...
This will start a new container some-mysql where the MySQL instance uses the combined startup settings from /etc/mysql/my.cnf and /etc/mysql/conf.d/config-file.cnf, with settings from the latter taking precedence.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can try altering the user instead if you don't like linking a config: https://dev.mysql.com/doc/refman/8.0/en/upgrading-from-previous-series.html#upgrade-caching-sha2-password

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's fine leaving it as is. I didn't realize it's the right way to do things and started asking, then realized but decided to post the question to make sure.

@morozov morozov force-pushed the ci-mysql8 branch 3 times, most recently from 306e409 to 6f2209c Compare June 16, 2018 21:43
@morozov morozov modified the milestones: 2.8.0, 2.9.0 Jun 19, 2018
@Majkl578 Majkl578 added the WIP label Jun 19, 2018
@Majkl578 Majkl578 closed this Dec 3, 2018
@Majkl578 Majkl578 deleted the ci-mysql8 branch December 3, 2018 02:07
@Majkl578 Majkl578 removed this from the 2.9.0 milestone Dec 3, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants