Drop support for legacy platforms#3055
Conversation
62336a0 to
e59f616
Compare
e59f616 to
a7f77ce
Compare
a7f77ce to
dbdac39
Compare
| 'datetime2' => 'datetime', | ||
| 'date' => 'date', | ||
| 'time' => 'time', | ||
| 'datetimeoffset' => 'datetimetz', |
There was a problem hiding this comment.
Would it make sense to have this sorted by key so that when you're looking for something, you don't have to use Ctrl + F?
There was a problem hiding this comment.
Done also for other platforms & keywords (separate commit).
| 'pgsql100' => PostgreSQL100Keywords::class, | ||
| 'oracle' => OracleKeywords::class, | ||
| 'db2' => DB2Keywords::class, | ||
| 'sqlanywhere' => SQLAnywhereKeywords::class, |
|
Changes:
|
40acdb6 to
31146e9
Compare
Majkl578
left a comment
There was a problem hiding this comment.
Highlighted 4 bugs that may be worth fixing in 2.x too.
| 'SUCCESSFUL', | ||
| 'AUDIT', | ||
| 'HAVING', | ||
| 'OFFLINE ', |
There was a problem hiding this comment.
Trailing space was a bug? Removed.
| 'SET', | ||
| 'AND', | ||
| 'FLOAT', | ||
| 'NOTFOUND ', |
There was a problem hiding this comment.
Trailing space was a bug? Removed.
| 'unsigned int' => 'integer', | ||
| 'numeric' => 'decimal', | ||
| 'smallint' => 'smallint', | ||
| 'unsigned smallint', 'smallint', |
There was a problem hiding this comment.
This was a bug - not a key-value mapping.
| 'smallint' => 'smallint', | ||
| 'unsigned smallint', 'smallint', | ||
| 'tinyint' => 'smallint', | ||
| 'unsigned tinyint', 'smallint', |
There was a problem hiding this comment.
This was a bug - not a key-value mapping.
Ocramius
left a comment
There was a problem hiding this comment.
👍
Noticed that we don't have any explicit mapping for PostgreSQL > 9.4, but that's eventually for a separate patch, and probably not relevant for newer setups (10.x)
Drops:
closes #3052
closes #3053
closes #3054
closes #3058