allow creating PRIMARY KEY AUTOINCREMENT fields for sqlite#2921
Closed
icewind1991 wants to merge 1 commit intodoctrine:masterfrom
icewind1991:sqlite-pk-autoincrement
Closed
allow creating PRIMARY KEY AUTOINCREMENT fields for sqlite#2921icewind1991 wants to merge 1 commit intodoctrine:masterfrom icewind1991:sqlite-pk-autoincrement
icewind1991 wants to merge 1 commit intodoctrine:masterfrom
icewind1991:sqlite-pk-autoincrement
Conversation
If a PRIMARY KEY field is defined in sqlite without autoincrement then keys might be reused when rows are deleted, explicitly settings autoincrement will prevent this. Autoincrement is not enabled by default due to additional overhead introduced with autoincrement bookkeeping and should only be enabled when the additional uniqueness is required.
Contributor
|
Tests are not passing here... |
Contributor
|
I updated the unit tests in PR #3141. |
Contributor
Contributor
|
Cool. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a PRIMARY KEY field is defined in sqlite without autoincrement then
keys might be reused when rows are deleted, explicitly settings autoincrement
will prevent this.
Autoincrement is not enabled by default due to additional overhead introduced
with autoincrement bookkeeping and should only be enabled when the additional
uniqueness is required.
See also #1861