This is most likely because we combine phpunit and ocular commands as independent ones, as if it was in bash with set +e:

dbal/.appveyor.yml

Lines 142 to 145 in 92920ed

    
                 if ($env:coverage -eq "yes") { 
        
                   vendor\bin\phpunit -c $($env:phpunit_config) --coverage-clover clover.xml 
        
                   appveyor-retry ocular code-coverage:upload --format=php-clover clover.xml 
        
                 } else {

We should use something like set -e for PowerShell or combine the commands via &&.

Example:

Microsoft Windows [Version 6.2.9200]
(c) 2012 Microsoft Corporation. All rights reserved.

C:\Users\Administrator>type test.ps1
non-existing-command
echo "I'm okay"

C:\Users\Administrator>powershell -ExecutionPolicy Unrestricted test.ps1
non-existing-command : The term 'non-existing-command' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At C:\Users\Administrator\test.ps1:1 char:1
+ non-existing-command
+ ~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (non-existing-command:String) []
   , CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

I'm okay

C:\Users\Administrator>echo %errorlevel%
0

A potential fix may be:

C:\Users\Administrator>type test.ps1
$ErrorActionPreference = "Stop"

non-existing-command
echo "I'm okay"

C:\Users\Administrator>powershell -ExecutionPolicy Unrestricted test.ps1
non-existing-command : The term 'non-existing-command' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is
correct and try again.
At C:\Users\Administrator\test.ps1:3 char:1
+ non-existing-command
+ ~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (non-existing-command:String) []
   , ParentContainsErrorRecordException
    + FullyQualifiedErrorId : CommandNotFoundException

C:\Users\Administrator>echo %errorlevel%
1

	if ($env:coverage -eq "yes") {
	vendor\bin\phpunit -c $($env:phpunit_config) --coverage-clover clover.xml
	appveyor-retry ocular code-coverage:upload --format=php-clover clover.xml
	} else {

Uh oh!

Failed AppVeyor build allowed to pass #3451

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions