Added support for server_version connection parameter#329
Closed
adrianolek wants to merge 3 commits intodoctrine:masterfrom
Closed
Added support for server_version connection parameter#329adrianolek wants to merge 3 commits intodoctrine:masterfrom
adrianolek wants to merge 3 commits intodoctrine:masterfrom
Conversation
Member
There was a problem hiding this comment.
please use an underscored version in the config, to fit the Symfony convention in YAML and XML files.
the name should then be mapped to the camelCased key used by Doctrine in the DI extension (we already do it a lot)
Contributor
Author
|
Done |
Member
There was a problem hiding this comment.
please add the end of line at the end of the file
Contributor
Author
There was a problem hiding this comment.
Should be ok now.
Member
|
Thank you @adrianolek. |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doctrine DBAL 2.5 will support platform version autodetection, additionally it allows specifying serverVersion connection parameter:
In symfony it can be useful eg. when warming up cache during build, so you don't need the db connection, but dbal 2.5 will try to autodetect server version anyway eg. during entity class metadata loading, then it will throw an exception because of unavailable connection. server_version parameter can be used to skip the autodetection.