Node: feat: Node.js 21.0.0 #15581

nodejs-github-bot · 2023-10-19T10:39:23Z

Pull Request: nodejs/docker-node#1981
@LaurentGoderre @PeterDaveHello @SimenB @Starefossen @nschonni @ttshivers

SimenB · 2023-10-19T11:03:45Z

Did LTS tags disappear, or am I reading the diff wrong 🤔

nschonni · 2023-10-19T13:26:31Z

Yeah, somethings off. 21 should be the new current, but LTS shouldn't be changing from 18

SimenB · 2023-10-19T14:31:29Z

Guessing it's due to maintenance date has come and gone: https://github.com/nodejs/docker-node/blob/ba45415915d09bedd0e7f62c0c72c5c3c651484a/versions.json#L125

LaurentGoderre · 2023-10-19T18:32:04Z

@SimenB I think it's because in the code, LTS for 20 only starts on Tuesday next week: https://github.com/nodejs/docker-node/blob/main/versions.json#L59 and maintenance started yesterday on 18 https://github.com/nodejs/docker-node/blob/main/versions.json#L125

SimenB · 2023-10-19T18:47:07Z

Which is correct, but we should probably keep 18 as LTS up until that point

…S and the new LTS start

github-actions · 2023-10-19T20:33:56Z

Diff for 4a9b312:

diff --git a/_bashbrew-cat b/_bashbrew-cat
index ee14493..1356fe2 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -42,42 +42,72 @@ Architectures: amd64, arm32v7, arm64v8
 GitCommit: bdf5edb771596f7e3998ff318c3098850261b17b
 Directory: 18/buster-slim
 
-Tags: 20, 20-bookworm, 20.8, 20.8-bookworm, 20.8.1, 20.8.1-bookworm, bookworm, current, current-bookworm, latest
+Tags: 20, 20-bookworm, 20.8, 20.8-bookworm, 20.8.1, 20.8.1-bookworm
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
 GitCommit: bdf5edb771596f7e3998ff318c3098850261b17b
 Directory: 20/bookworm
 
-Tags: 20-alpine, 20-alpine3.18, 20.8-alpine, 20.8-alpine3.18, 20.8.1-alpine, 20.8.1-alpine3.18, alpine, alpine3.18, current-alpine, current-alpine3.18
+Tags: 20-alpine, 20-alpine3.18, 20.8-alpine, 20.8-alpine3.18, 20.8.1-alpine, 20.8.1-alpine3.18
 Architectures: amd64, arm32v6, arm32v7, arm64v8, ppc64le, s390x
 GitCommit: 6c20762ebfb6ab35c874c4fe540a55ab8fd6c49d
 Directory: 20/alpine3.18
 
-Tags: 20-alpine3.17, 20.8-alpine3.17, 20.8.1-alpine3.17, alpine3.17, current-alpine3.17
+Tags: 20-alpine3.17, 20.8-alpine3.17, 20.8.1-alpine3.17
 Architectures: amd64, arm32v6, arm32v7, arm64v8, ppc64le, s390x
 GitCommit: 6c20762ebfb6ab35c874c4fe540a55ab8fd6c49d
 Directory: 20/alpine3.17
 
-Tags: 20-bookworm-slim, 20-slim, 20.8-bookworm-slim, 20.8-slim, 20.8.1-bookworm-slim, 20.8.1-slim, bookworm-slim, current-bookworm-slim, current-slim, slim
+Tags: 20-bookworm-slim, 20-slim, 20.8-bookworm-slim, 20.8-slim, 20.8.1-bookworm-slim, 20.8.1-slim
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
 GitCommit: bdf5edb771596f7e3998ff318c3098850261b17b
 Directory: 20/bookworm-slim
 
-Tags: 20-bullseye, 20.8-bullseye, 20.8.1-bullseye, bullseye, current-bullseye
+Tags: 20-bullseye, 20.8-bullseye, 20.8.1-bullseye
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
 GitCommit: bdf5edb771596f7e3998ff318c3098850261b17b
 Directory: 20/bullseye
 
-Tags: 20-bullseye-slim, 20.8-bullseye-slim, 20.8.1-bullseye-slim, bullseye-slim, current-bullseye-slim
+Tags: 20-bullseye-slim, 20.8-bullseye-slim, 20.8.1-bullseye-slim
 Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
 GitCommit: bdf5edb771596f7e3998ff318c3098850261b17b
 Directory: 20/bullseye-slim
 
-Tags: 20-buster, 20.8-buster, 20.8.1-buster, buster, current-buster
+Tags: 20-buster, 20.8-buster, 20.8.1-buster
 Architectures: amd64, arm32v7, arm64v8
 GitCommit: bdf5edb771596f7e3998ff318c3098850261b17b
 Directory: 20/buster
 
-Tags: 20-buster-slim, 20.8-buster-slim, 20.8.1-buster-slim, buster-slim, current-buster-slim
+Tags: 20-buster-slim, 20.8-buster-slim, 20.8.1-buster-slim
 Architectures: amd64, arm32v7, arm64v8
 GitCommit: bdf5edb771596f7e3998ff318c3098850261b17b
 Directory: 20/buster-slim
+
+Tags: 21, 21-bookworm, 21.0, 21.0-bookworm, 21.0.0, 21.0.0-bookworm, bookworm, current, current-bookworm, latest
+Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
+GitCommit: 593dd75b22cbaf846e223b9b48736fc7b7b27871
+Directory: 21/bookworm
+
+Tags: 21-alpine, 21-alpine3.18, 21.0-alpine, 21.0-alpine3.18, 21.0.0-alpine, 21.0.0-alpine3.18, alpine, alpine3.18, current-alpine, current-alpine3.18
+Architectures: amd64, arm32v6, arm32v7, arm64v8, ppc64le, s390x
+GitCommit: c3b405debb5e5153fc2ace45097e2d7a4e0fa20f
+Directory: 21/alpine3.18
+
+Tags: 21-alpine3.17, 21.0-alpine3.17, 21.0.0-alpine3.17, alpine3.17, current-alpine3.17
+Architectures: amd64, arm32v6, arm32v7, arm64v8, ppc64le, s390x
+GitCommit: c3b405debb5e5153fc2ace45097e2d7a4e0fa20f
+Directory: 21/alpine3.17
+
+Tags: 21-bookworm-slim, 21-slim, 21.0-bookworm-slim, 21.0-slim, 21.0.0-bookworm-slim, 21.0.0-slim, bookworm-slim, current-bookworm-slim, current-slim, slim
+Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
+GitCommit: 593dd75b22cbaf846e223b9b48736fc7b7b27871
+Directory: 21/bookworm-slim
+
+Tags: 21-bullseye, 21.0-bullseye, 21.0.0-bullseye, bullseye, current-bullseye
+Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
+GitCommit: 593dd75b22cbaf846e223b9b48736fc7b7b27871
+Directory: 21/bullseye
+
+Tags: 21-bullseye-slim, 21.0-bullseye-slim, 21.0.0-bullseye-slim, bullseye-slim, current-bullseye-slim
+Architectures: amd64, arm32v7, arm64v8, ppc64le, s390x
+GitCommit: 593dd75b22cbaf846e223b9b48736fc7b7b27871
+Directory: 21/bullseye-slim
diff --git a/_bashbrew-list b/_bashbrew-list
index f2839f6..3c19783 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -64,6 +64,33 @@ node:20.8.1-bullseye-slim
 node:20.8.1-buster
 node:20.8.1-buster-slim
 node:20.8.1-slim
+node:21
+node:21-alpine
+node:21-alpine3.17
+node:21-alpine3.18
+node:21-bookworm
+node:21-bookworm-slim
+node:21-bullseye
+node:21-bullseye-slim
+node:21-slim
+node:21.0
+node:21.0-alpine
+node:21.0-alpine3.17
+node:21.0-alpine3.18
+node:21.0-bookworm
+node:21.0-bookworm-slim
+node:21.0-bullseye
+node:21.0-bullseye-slim
+node:21.0-slim
+node:21.0.0
+node:21.0.0-alpine
+node:21.0.0-alpine3.17
+node:21.0.0-alpine3.18
+node:21.0.0-bookworm
+node:21.0.0-bookworm-slim
+node:21.0.0-bullseye
+node:21.0.0-bullseye-slim
+node:21.0.0-slim
 node:alpine
 node:alpine3.17
 node:alpine3.18
@@ -71,8 +98,6 @@ node:bookworm
 node:bookworm-slim
 node:bullseye
 node:bullseye-slim
-node:buster
-node:buster-slim
 node:current
 node:current-alpine
 node:current-alpine3.17
@@ -81,8 +106,6 @@ node:current-bookworm
 node:current-bookworm-slim
 node:current-bullseye
 node:current-bullseye-slim
-node:current-buster
-node:current-buster-slim
 node:current-slim
 node:hydrogen
 node:hydrogen-alpine
diff --git a/_bashbrew-list-build-order b/_bashbrew-list-build-order
index 03811c9..7961d07 100644
--- a/_bashbrew-list-build-order
+++ b/_bashbrew-list-build-order
@@ -6,11 +6,17 @@ node:lts-bullseye
 node:lts-bullseye-slim
 node:lts-buster
 node:lts-buster-slim
+node:20.8.1-bookworm
+node:20.8.1-alpine3.18
+node:20.8.1-alpine3.17
+node:20.8.1-slim
+node:20.8.1-bullseye
+node:20.8.1-bullseye-slim
+node:20.8.1-buster
+node:20.8.1-buster-slim
 node:latest
 node:current-alpine3.18
 node:current-alpine3.17
 node:slim
 node:current-bullseye
 node:current-bullseye-slim
-node:current-buster
-node:current-buster-slim
diff --git a/node_current-alpine3.17/Dockerfile b/node_20.8.1-alpine3.17/Dockerfile
similarity index 100%
copy from node_current-alpine3.17/Dockerfile
copy to node_20.8.1-alpine3.17/Dockerfile
diff --git a/node_current-buster-slim/docker-entrypoint.sh b/node_20.8.1-alpine3.17/docker-entrypoint.sh
similarity index 100%
rename from node_current-buster-slim/docker-entrypoint.sh
rename to node_20.8.1-alpine3.17/docker-entrypoint.sh
diff --git a/node_current-alpine3.18/Dockerfile b/node_20.8.1-alpine3.18/Dockerfile
similarity index 100%
copy from node_current-alpine3.18/Dockerfile
copy to node_20.8.1-alpine3.18/Dockerfile
diff --git a/node_current-buster/docker-entrypoint.sh b/node_20.8.1-alpine3.18/docker-entrypoint.sh
similarity index 100%
rename from node_current-buster/docker-entrypoint.sh
rename to node_20.8.1-alpine3.18/docker-entrypoint.sh
diff --git a/node_latest/Dockerfile b/node_20.8.1-bookworm/Dockerfile
similarity index 100%
copy from node_latest/Dockerfile
copy to node_20.8.1-bookworm/Dockerfile
diff --git a/node_current-alpine3.17/docker-entrypoint.sh b/node_20.8.1-bookworm/docker-entrypoint.sh
similarity index 100%
copy from node_current-alpine3.17/docker-entrypoint.sh
copy to node_20.8.1-bookworm/docker-entrypoint.sh
diff --git a/node_current-bullseye-slim/Dockerfile b/node_20.8.1-bullseye-slim/Dockerfile
similarity index 100%
copy from node_current-bullseye-slim/Dockerfile
copy to node_20.8.1-bullseye-slim/Dockerfile
diff --git a/node_current-alpine3.17/docker-entrypoint.sh b/node_20.8.1-bullseye-slim/docker-entrypoint.sh
similarity index 100%
copy from node_current-alpine3.17/docker-entrypoint.sh
copy to node_20.8.1-bullseye-slim/docker-entrypoint.sh
diff --git a/node_current-bullseye/Dockerfile b/node_20.8.1-bullseye/Dockerfile
similarity index 100%
copy from node_current-bullseye/Dockerfile
copy to node_20.8.1-bullseye/Dockerfile
diff --git a/node_current-alpine3.17/docker-entrypoint.sh b/node_20.8.1-bullseye/docker-entrypoint.sh
similarity index 100%
copy from node_current-alpine3.17/docker-entrypoint.sh
copy to node_20.8.1-bullseye/docker-entrypoint.sh
diff --git a/node_current-buster-slim/Dockerfile b/node_20.8.1-buster-slim/Dockerfile
similarity index 100%
rename from node_current-buster-slim/Dockerfile
rename to node_20.8.1-buster-slim/Dockerfile
diff --git a/node_current-alpine3.17/docker-entrypoint.sh b/node_20.8.1-buster-slim/docker-entrypoint.sh
similarity index 100%
copy from node_current-alpine3.17/docker-entrypoint.sh
copy to node_20.8.1-buster-slim/docker-entrypoint.sh
diff --git a/node_current-buster/Dockerfile b/node_20.8.1-buster/Dockerfile
similarity index 100%
rename from node_current-buster/Dockerfile
rename to node_20.8.1-buster/Dockerfile
diff --git a/node_current-alpine3.17/docker-entrypoint.sh b/node_20.8.1-buster/docker-entrypoint.sh
similarity index 100%
copy from node_current-alpine3.17/docker-entrypoint.sh
copy to node_20.8.1-buster/docker-entrypoint.sh
diff --git a/node_slim/Dockerfile b/node_20.8.1-slim/Dockerfile
similarity index 100%
copy from node_slim/Dockerfile
copy to node_20.8.1-slim/Dockerfile
diff --git a/node_current-alpine3.17/docker-entrypoint.sh b/node_20.8.1-slim/docker-entrypoint.sh
similarity index 100%
copy from node_current-alpine3.17/docker-entrypoint.sh
copy to node_20.8.1-slim/docker-entrypoint.sh
diff --git a/node_current-alpine3.17/Dockerfile b/node_current-alpine3.17/Dockerfile
index e735694..c1c7476 100644
--- a/node_current-alpine3.17/Dockerfile
+++ b/node_current-alpine3.17/Dockerfile
@@ -1,6 +1,6 @@
 FROM alpine:3.17
 
-ENV NODE_VERSION 20.8.1
+ENV NODE_VERSION 21.0.0
 
 RUN addgroup -g 1000 node \
     && adduser -u 1000 -G node -s /bin/sh -D node \
@@ -12,7 +12,7 @@ RUN addgroup -g 1000 node \
       && case "${alpineArch##*-}" in \
         x86_64) \
           ARCH='x64' \
-          CHECKSUM="15a1120027d72ff891cd9ce6e6705181cd589e609f94aca362f2d32fc9871a14" \
+          CHECKSUM="d69d70fb49598ab5bb18b270fd828d524f52b703a39ae15d5d24193baf93c3bf" \
           ;; \
         *) ;; \
       esac \
diff --git a/node_current-alpine3.18/Dockerfile b/node_current-alpine3.18/Dockerfile
index 91edd35..b44d2f9 100644
--- a/node_current-alpine3.18/Dockerfile
+++ b/node_current-alpine3.18/Dockerfile
@@ -1,6 +1,6 @@
 FROM alpine:3.18
 
-ENV NODE_VERSION 20.8.1
+ENV NODE_VERSION 21.0.0
 
 RUN addgroup -g 1000 node \
     && adduser -u 1000 -G node -s /bin/sh -D node \
@@ -12,7 +12,7 @@ RUN addgroup -g 1000 node \
       && case "${alpineArch##*-}" in \
         x86_64) \
           ARCH='x64' \
-          CHECKSUM="15a1120027d72ff891cd9ce6e6705181cd589e609f94aca362f2d32fc9871a14" \
+          CHECKSUM="d69d70fb49598ab5bb18b270fd828d524f52b703a39ae15d5d24193baf93c3bf" \
           ;; \
         *) ;; \
       esac \
diff --git a/node_current-bullseye-slim/Dockerfile b/node_current-bullseye-slim/Dockerfile
index 65f20f2..5b7df1b 100644
--- a/node_current-bullseye-slim/Dockerfile
+++ b/node_current-bullseye-slim/Dockerfile
@@ -3,7 +3,7 @@ FROM debian:bullseye-slim
 RUN groupadd --gid 1000 node \
   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
 
-ENV NODE_VERSION 20.8.1
+ENV NODE_VERSION 21.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
     && case "${dpkgArch##*-}" in \
diff --git a/node_current-bullseye/Dockerfile b/node_current-bullseye/Dockerfile
index a45fd96..785016e 100644
--- a/node_current-bullseye/Dockerfile
+++ b/node_current-bullseye/Dockerfile
@@ -3,7 +3,7 @@ FROM buildpack-deps:bullseye
 RUN groupadd --gid 1000 node \
   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
 
-ENV NODE_VERSION 20.8.1
+ENV NODE_VERSION 21.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_latest/Dockerfile b/node_latest/Dockerfile
index 3ed4dfb..e151aaa 100644
--- a/node_latest/Dockerfile
+++ b/node_latest/Dockerfile
@@ -3,7 +3,7 @@ FROM buildpack-deps:bookworm
 RUN groupadd --gid 1000 node \
   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
 
-ENV NODE_VERSION 20.8.1
+ENV NODE_VERSION 21.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \
diff --git a/node_slim/Dockerfile b/node_slim/Dockerfile
index cc065f9..a52c0e3 100644
--- a/node_slim/Dockerfile
+++ b/node_slim/Dockerfile
@@ -3,7 +3,7 @@ FROM debian:bookworm-slim
 RUN groupadd --gid 1000 node \
   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
 
-ENV NODE_VERSION 20.8.1
+ENV NODE_VERSION 21.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
     && case "${dpkgArch##*-}" in \

Relevant Maintainers:

node: @nodejs

LaurentGoderre · 2023-10-19T21:19:28Z

Diff looks right to me but can you double check @SimenB ?

SimenB · 2023-10-19T21:44:11Z

Agreed 👍 only change is new 21 and current moved to that (from what I can see)

SimenB · 2023-10-19T21:45:14Z

Or, node:buster is gone - while we removed buster for 21, shouldn't that remain on 20? Not sure.

LaurentGoderre · 2023-10-19T22:28:33Z

@SimenB I think what's happening is buster is still there but the shorthand doesn't exist anymore because semantically buster was equivalent to current-buster so current is 21 and buster doesn't exist for it

yosifkit · 2023-10-19T23:02:54Z

Going to merge to get the new version out. Feel free to add back the buster tag if it is important.

github-actions bot mentioned this pull request Oct 19, 2023

feat: Node.js 21.0.0 nodejs/docker-node#1980

Merged

12 tasks

github-actions bot added the library/node label Oct 19, 2023

This comment has been minimized.

Sign in to view

Node: Fix the gap between the start of a maintenance period for an LT…

4a9b312

…S and the new LTS start

nodejs-github-bot changed the title ~~Node: feat: Node.js 21.0.0~~ Node: Fix the gap between the start of a maintenance period for an LTS and the new LTS start Oct 19, 2023

nodejs-github-bot force-pushed the node branch from a45ab6d to 4a9b312 Compare October 19, 2023 20:31

github-actions bot mentioned this pull request Oct 19, 2023

Fix the gap between the start of a maintenance period for an LTS and the new LTS start nodejs/docker-node#1981

Merged

LaurentGoderre changed the title ~~Node: Fix the gap between the start of a maintenance period for an LTS and the new LTS start~~ Node: feat: Node.js 21.0.0 Oct 19, 2023

LaurentGoderre approved these changes Oct 19, 2023

View reviewed changes

yosifkit approved these changes Oct 19, 2023

View reviewed changes

yosifkit merged commit a7ec0f3 into docker-library:master Oct 19, 2023

SimenB deleted the node branch October 20, 2023 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Node: feat: Node.js 21.0.0 #15581

Node: feat: Node.js 21.0.0 #15581

Uh oh!

nodejs-github-bot commented Oct 19, 2023 •

edited

Loading

Uh oh!

This comment has been minimized.

SimenB commented Oct 19, 2023

Uh oh!

nschonni commented Oct 19, 2023

Uh oh!

SimenB commented Oct 19, 2023

Uh oh!

LaurentGoderre commented Oct 19, 2023 •

edited

Loading

Uh oh!

SimenB commented Oct 19, 2023

Uh oh!

github-actions bot commented Oct 19, 2023

Uh oh!

LaurentGoderre commented Oct 19, 2023 •

edited

Loading

Uh oh!

SimenB commented Oct 19, 2023

Uh oh!

SimenB commented Oct 19, 2023

Uh oh!

LaurentGoderre commented Oct 19, 2023

Uh oh!

yosifkit commented Oct 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Node: feat: Node.js 21.0.0 #15581

Node: feat: Node.js 21.0.0 #15581

Uh oh!

Conversation

nodejs-github-bot commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

SimenB commented Oct 19, 2023

Uh oh!

nschonni commented Oct 19, 2023

Uh oh!

SimenB commented Oct 19, 2023

Uh oh!

LaurentGoderre commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SimenB commented Oct 19, 2023

Uh oh!

github-actions bot commented Oct 19, 2023

Uh oh!

LaurentGoderre commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SimenB commented Oct 19, 2023

Uh oh!

SimenB commented Oct 19, 2023

Uh oh!

LaurentGoderre commented Oct 19, 2023

Uh oh!

yosifkit commented Oct 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nodejs-github-bot commented Oct 19, 2023 •

edited

Loading

LaurentGoderre commented Oct 19, 2023 •

edited

Loading

LaurentGoderre commented Oct 19, 2023 •

edited

Loading