Skip to content

Commit 5c3ba9a

Browse files
authored
Merge pull request #1219 from pedro93/fix-3.1.3-rc-create-container-missing-regression
Reverts create container cmd regression.
2 parents 99e79bb + 6f00250 commit 5c3ba9a

File tree

2 files changed

+45
-0
lines changed

2 files changed

+45
-0
lines changed

src/main/java/com/github/dockerjava/api/command/CreateContainerCmd.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,20 @@ public interface CreateContainerCmd extends SyncDockerCmd<CreateContainerRespons
158158

159159
CreateContainerCmd withMacAddress(String macAddress);
160160

161+
@Deprecated
162+
@CheckForNull
163+
Long getMemory();
164+
165+
@Deprecated
166+
CreateContainerCmd withMemory(Long memory);
167+
168+
@Deprecated
169+
@CheckForNull
170+
Long getMemorySwap();
171+
172+
@Deprecated
173+
CreateContainerCmd withMemorySwap(Long memorySwap);
174+
161175
@CheckForNull
162176
String getName();
163177

src/main/java/com/github/dockerjava/core/command/CreateContainerCmdImpl.java

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,37 @@ public CreateContainerCmd withMacAddress(String macAddress) {
380380
return this;
381381
}
382382

383+
@Deprecated
384+
@Override
385+
@JsonIgnore
386+
public Long getMemory() {
387+
return hostConfig.getMemory();
388+
}
389+
390+
@Deprecated
391+
@Override
392+
public CreateContainerCmd withMemory(Long memory) {
393+
checkNotNull(memory, "memory was not specified");
394+
hostConfig.withMemory(memory);
395+
return this;
396+
}
397+
398+
@Deprecated
399+
@Override
400+
@JsonIgnore
401+
public Long getMemorySwap() {
402+
return hostConfig.getMemorySwap();
403+
}
404+
405+
@Deprecated
406+
@Override
407+
public CreateContainerCmd withMemorySwap(Long memorySwap) {
408+
checkNotNull(memorySwap, "memorySwap was not specified");
409+
hostConfig.withMemorySwap(memorySwap);
410+
return this;
411+
}
412+
413+
383414
@Override
384415
public String getName() {
385416
return name;

0 commit comments

Comments
 (0)