This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Add NetworkAttachmentConfig to TaskSpec #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change NetworkAttachmentConfig moves to TaskSpec. We will continue to support setting the NetworkAttachmentConfig in ServiceSpec in addition to supporting it in TaskSpec. Also added `ManuallyAttachable` flag to NetworkCreateRequest and NetworkResource types. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
| Resources *ResourceRequirements `json:",omitempty"` | ||
| RestartPolicy *RestartPolicy `json:",omitempty"` | ||
| Placement *Placement `json:",omitempty"` | ||
| Networks []NetworkAttachmentConfig `json:",omitempty"` |
Contributor
There was a problem hiding this comment.
Remember to add a compat note for this field.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change NetworkAttachmentConfig moves to TaskSpec. We will
continue to support setting the NetworkAttachmentConfig in ServiceSpec
in addition to supporting it in TaskSpec.
Also added
Attachableflag to NetworkCreateRequest andNetworkResource types.
Signed-off-by: Jana Radhakrishnan mrjana@docker.com