Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

types: new seccomp format#313

Merged
vdemeester merged 1 commit intodocker-archive-public:masterfrom
runcom:new-seccomp-format
Aug 31, 2016
Merged

types: new seccomp format#313
vdemeester merged 1 commit intodocker-archive-public:masterfrom
runcom:new-seccomp-format

Conversation

@runcom
Copy link
Contributor

@runcom runcom commented Jul 13, 2016

engine-api changes related to moby/moby#24510

/cc @justincormack

Signed-off-by: Antonio Murdaca runcom@redhat.com

@vdemeester
Copy link
Contributor

vdemeester commented Jul 13, 2016

/cc @justincormack

Syscalls []*Syscall `json:"syscalls"`
DefaultAction Action `json:"defaultAction"`
Architectures []Arch `json:"architectures,omitempty"`
ArchMap []Architecture `json:"archMap,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a bit of duplication (or I don't really get it 😅), but I guess this is for retro-compatibility right ? (if yes, a comment about that would be perfect 😝 )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is designed to be fully compatible.

On 31 Aug 2016 13:39, "Vincent Demeester" notifications@github.com wrote:

In types/seccomp.go
#313 (comment):

@@ -2,12 +2,20 @@ package types

// Seccomp represents the config for a seccomp profile for syscall restriction.
type Seccomp struct {

  • DefaultAction Action json:"defaultAction"
  • Architectures []Arch json:"architectures"
  • Syscalls []*Syscall json:"syscalls"
  • DefaultAction Action json:"defaultAction"
  • Architectures []Arch json:"architectures,omitempty"
  • ArchMap []Architecture json:"archMap,omitempty"

This looks like a bit of duplication (or I don't really get it 😅), but I
guess this is for retro-compatibility right ? (if yes, a comment about that
would be perfect 😝 )


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/engine-api/pull/313/files/b4b3edb80a5aabf9567a769e2aca4b6913aed800#r76979496,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdcPOZaWoWoNEnLRhBuT3MS1VF3alvrks5qlXYegaJpZM4JLbHs
.

@vdemeester
Copy link
Contributor

Quick question, otherwise LGTM 🐸

@justincormack
Copy link

LGTM

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom runcom force-pushed the new-seccomp-format branch from b4b3edb to 2ecb579 Compare August 31, 2016 14:22
@vdemeester vdemeester merged commit f9cef59 into docker-archive-public:master Aug 31, 2016
@runcom runcom deleted the new-seccomp-format branch August 31, 2016 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants