moby image: add docker.io container registry#314
Closed
Frankkkkk wants to merge 1 commit intodocker:masterfrom
Closed
moby image: add docker.io container registry#314Frankkkkk wants to merge 1 commit intodocker:masterfrom
moby image: add docker.io container registry#314Frankkkkk wants to merge 1 commit intodocker:masterfrom
Conversation
In docker, the container registry is supposed to be `docker.io`, but it can be others or even be undefined in other container runtimes (e.g. podman). Signed-off-by: Frank Villaro-Dixon <frank@villaro-dixon.eu>
crazy-max
reviewed
Apr 12, 2024
Author
|
Hi,
I understand your reticence as it could concurrence the Docker product.
However, for the technical reasons: this action is used in GitHub, but also on other forges such as Gitea or Forgejo (they both use act). The runners on these can use other container runtimes, and in this case this action would fail as the registry is not specified.
Thanks,
Kind regards
…On 12 April 2024 12:18:48 CEST, CrazyMax ***@***.***> wrote:
@crazy-max commented on this pull request.
This is used through Docker, Inc products so this is not necessary outside this scope for other tools such as Podman.
Closing this but let us know if you have a reproducible case. Thanks.
--
Reply to this email directly or view it on GitHub:
#314 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Member
Internally this image is pulled using the Docker API when executing the Will think about it and come back to you but in the meantime you can still define the image tag yourself using: https://docs.docker.com/build/ci/github-actions/configure-builder/#version-pinning - name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
with:
driver-opts: image=docker.io/moby/buildkit:latestWould also need to align tags on buildx side https://github.com/docker/buildx/blob/df7a3db94712c748766dbf033741987deecc6daa/driver/bkimage/bkimage.go#L4-L5 if we agree with this (cc @tonistiigi @thompson-shaun) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In docker, the container registry is supposed to be
docker.io, but it can be others or even be undefined in other container runtimes (e.g. podman).Thanks!