This repository was archived by the owner on Jul 31, 2025. It is now read-only.
Introduce notary reset command from notary status flags
#959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
Contributor
|
Non-blocking nitpick: Wondering if |
Contributor
Author
|
@cyli: agreed! |
ce64309 to
e123918
Compare
cyli
approved these changes
Sep 15, 2016
Contributor
cyli
left a comment
There was a problem hiding this comment.
Awesome, thanks for fixing this! LGTM
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
e123918 to
360c691
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factors out the
--resetand--unstageflags fromnotary statusinto a newnotary resetcommand.The
notary statuscommand now does not have any flags and cannot mutate any state.notary reset <GUN> --allresets all staged changes for a gunnotary reset <GUN> -n 1 -n 2resets the change items numbered1and2fromnotary status <GUN>Signed-off-by: Riyaz Faizullabhoy riyaz.faizullabhoy@docker.com