This repository was archived by the owner on Jul 18, 2025. It is now read-only.
add netmode for docker build #159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sandyskies <chenmingjie0828@163.com>
Contributor
|
We just discussed the associated PR in docker/docker, and this should not be merged yet, pending moby/moby#20987 (comment) |
Contributor
|
Thanks for this PR. We have moved the code from this repo back into the main docker/docker repository; if you still wish to make this change you will need to reopen this PR on the main repo. You can find the code for the client and types here: https://github.com/docker/docker/tree/master/api/types Sorry for the inconvenience but making this change helps people better contribute and not have the vendor mess going forward when changing the types or client for Docker. Sorry about that and feel free to ask if you have any questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create for PR 20987
docker could't point a network mode when build a image ,in my case, we are unable to use bridge network mode because my company's restriction. So I add --net options for docker build command to use host network mode.
In order to add this support , I have to change engine-api , So I create this PR.
Signed-off-by: sandyskies chenmingjie0828@163.com