This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] Propagate GetContainer error from event processor#407
Merged
andrewhsu merged 1 commit intodocker-archive:19.03from Oct 28, 2019
Merged
Conversation
Before this change we just accept that any error is "not found" and it could be something else, but even if it it is just a "not found" kind of error this should be dealt with from the container store and not the event processor. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 54e30a6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
cpuguy83
approved these changes
Oct 17, 2019
cpuguy83
left a comment
There was a problem hiding this comment.
Oh I didn't realize this didn't make it in before.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of moby#39497
Before this change we just accept that any error is "not found" and it
could be something else, but even if it it is just a "not found" kind of
error this should be dealt with from the container store and not the
event processor.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)