Fix proxy documentation- * as wildcard is not supported#12463
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| You can optionally exclude hosts or ranges from going through the proxy | ||
| server by setting a `noProxy` key to one or more comma-separated IP | ||
| addresses or hosts. Using the `*` character as a wildcard for hosts and using CIDR notation for IP addresses is supported as | ||
| addresses or hosts. Prefixing domain with a dot `.` acts as a wildcard for hosts and using CIDR notation for IP addresses is supported as |
There was a problem hiding this comment.
Hm.. yes, these are "complicated", as the supported formats are not formalised. Perhaps we should mention something about that (supported formats depend on the software that's using the NO_PROXY (and other _PROXY/ _proxy vars), and we could link to the Go documentation, and possibly copy some of that; https://pkg.go.dev/golang.org/x/net/http/httpproxy#Config
NoProxy represents the NO_PROXY or no_proxy environment
variable. It specifies a string that contains comma-separated values
specifying hosts that should be excluded from proxying. Each value is
represented by an IP address prefix (1.2.3.4), an IP address prefix in
CIDR notation (1.2.3.4/8), a domain name, or a special DNS label (*).
An IP address prefix and domain name can also include a literal port
number (1.2.3.4:80).
A domain name matches that name and all subdomains. A domain name with
a leading "." matches subdomains only. For example "foo.com" matches
"foo.com" and "bar.foo.com"; ".y.com" matches "x.y.com" but not "y.com".
A single asterisk (*) indicates that no proxying should be done.
I seem to recall we did that somewhere (but it could be I started working on it, but never pushed a PR 🤔)
|
Looks like this needs a rebase; otherwise this looks good to me (we can look at the improvements in a follow-up) |
According to documentation we can use * as a wild card for noProxy, this is not working. And according to https://www.gnu.org/software/wget/manual/html_node/Proxies.html we need to prefix with a dot.
rebase done |
|
@thaJeztah can we already merge this version ? |
|
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
Proposed changes
Updated proxy documentation
According to documentation we can use * as a wild card for noProxy, this is not working.
And according to https://www.gnu.org/software/wget/manual/html_node/Proxies.html we need to prefix with a dot.
Related issue
#9745