Update debian.md #11974
Update debian.md #11974
Conversation
Added workaround for `apt-key` deprecation errors
|
✔️ Deploy preview for docsdocker ready! 🔨 Explore the source changes: 11775ed 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docsdocker/deploys/5fe44fef5d8d64000702f125 😎 Browse the preview: https://deploy-preview-11974--docsdocker.netlify.app |
|
I noticed the workaround still make use of the deprecated I believe a more future-proof approach would be to discontinue use of |
| ``` | ||
| then you can avoid it by using the following instead: | ||
| ``` | ||
| curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key --keyring /etc/apt/trusted.gpg.d/docker-apt-key.gpg add - |
There was a problem hiding this comment.
Does this also work on older versions? If so, we should probably replace the existing instructions to use the new one
This should probably also use the variable;
| curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key --keyring /etc/apt/trusted.gpg.d/docker-apt-key.gpg add - | |
| curl -fsSL {{ download-url-base }}/gpg | sudo apt-key --keyring /etc/apt/trusted.gpg.d/docker-apt-key.gpg add - |
There was a problem hiding this comment.
Good day @thaJeztah
As per my previous comment, this solution and the requested changes still rely on the deprecated apt-key tool.
#11990 offers a Debian-compliant way of dealing with apt-key deprecation that applies to Debian 9 (Stretch) / Ubuntu 16.04 (Xenial) onward which is in line with Docker's own installation requirements.
Thank you :)
There was a problem hiding this comment.
I believe the verification command needs also --keyring /etc/apt/trusted.gpg.d/docker-apt-key.gpg, below.
Proposed changes
Added workaround for
apt-keydeprecation errors.The installation instructions for Debian use a plain
sudo apt-key add -toadd the gpg fingerprint, resulting in errors when trying to install on newer
Debian builds, as detailed in #11625 . The workaround is copied from this comment.
Related issues (optional)
#11625