Conversation
Inspect output for 'NetworkSettings.Networks.<network>.Aliases' includes the container's short-id (although it will be removed in API v1.45, in moby 26.0). Signed-off-by: Rob Murray <rob.murray@docker.com>
d9c8672 to
cb21af7
Compare
|
It turns out that, while the docker <= 25.0 does include the short-id in inspect output for a running container, the result of docker-py's Which explains why the tests had been passing ... and highlights an inadvertent change in docker 25.0. (In 25.0, docker uses the API version to decide whether to include the short-id, but it doesn't precisely match the 24.0 behaviour. In 24.0, inspect after the container's started includes short-id, even once the container's been stopped again.) We're not planning to fix that, as it's a bit subtle and inconsistent - but it means we need to include this change to the tests in the change that bumps docker-py to 25.0. (It'll still need to be reverted when we bump to 26.0 / API version 1.45, because the API is deliberately changed to exclude it in that version.) |
With Docker Engine 24.x, 25.x (and probably older versions),
inspectoutput forNetworkSettings.Networks.<network>.Aliasesincludes the container's short-id.(The short-id will be removed from 'Aliases' in API v1.45, in moby 26.0. So, this change will need to be reverted when docker-py is updated to that version.)